[VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1

Discussion:

[VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

Tibor Digana

2018-11-04 10:48:15 UTC

Hi,

We solved 4 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1466/
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip

Source release checksum(s):
surefire-3.0.0-M1-source-release.zip sha512:
2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94
surefire-3.0.0-M1-source-release.zip sha1:
72830b8d82bd068ab7da5eaeb4da8a66b8ea600d

Staging site:
http://maven.apache.org/surefire-archives/surefire-LATEST/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Cheers
Tibor

Tibor Digana

2018-11-04 10:49:07 UTC

Permalink

One important remark regarding testing with JDK 9+.
The Surefire project runs itself tests within maven-surefire-plugin:2.12.4
which properly isolates project classes and plugin's classes.
Next version 3.0.0-M2 should load user's classes in IsolatedClassLoader
(configured by parameter in POM).
Due to we do not have this possibility now, we are able to test only with
such Java Specification Version which is 3 characters long at least, i.e.
9.0.1.

Post by Tibor Digana
Hi,
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
https://repository.apache.org/content/repositories/maven-1466/
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip
2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94
72830b8d82bd068ab7da5eaeb4da8a66b8ea600d
http://maven.apache.org/surefire-archives/surefire-LATEST/
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
Cheers
Tibor

Eric Lilja

2018-11-04 16:11:53 UTC

Permalink

+1 (non-binding)

When testing on my personal projects, I did see one JUnit test failure
on some very old code, a test which didn't have any problems on surefire
2.18.1-2.22.1. I examined the test and came to the conclusion that is
was misbehaved as it tried to treat a classpath resource as a file
system resource. I re-wrote the test and now it works on both both
3.0.0-M1 and older versions. But I guess others will see similar
failures if they have poorly written code like I had in that testcase.

I tested using a clean .m2 and ran a script which builds all my projects
in dependency order. I noticed the process took a lot longer than usual
after adding the staging repo, but I solved that by adding the default
plugin repo as well.

By the way, there were five issues closed, not four, which is not a bad
thing, just a tiny error in the vote email text :)

- Eric Lilja

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org

Tibor Digana

2018-11-04 16:47:17 UTC

Permalink

Well, yes there should be two repos.
One is Maven Central and the second is the staging because the ASF staging
Nexus is not a copy of Central. There are only our Apache artifacts
deployed.

Post by Eric Lilja
+1 (non-binding)
When testing on my personal projects, I did see one JUnit test failure
on some very old code, a test which didn't have any problems on surefire
2.18.1-2.22.1. I examined the test and came to the conclusion that is
was misbehaved as it tried to treat a classpath resource as a file
system resource. I re-wrote the test and now it works on both both
3.0.0-M1 and older versions. But I guess others will see similar
failures if they have poorly written code like I had in that testcase.
I tested using a clean .m2 and ran a script which builds all my projects
in dependency order. I noticed the process took a lot longer than usual
after adding the staging repo, but I solved that by adding the default
plugin repo as well.
By the way, there were five issues closed, not four, which is not a bad
thing, just a tiny error in the vote email text :)
- Eric Lilja

Post by Tibor Digana
Hi,

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC

Post by Tibor Digana
https://repository.apache.org/content/repositories/maven-1466/

https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip
2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94

Post by Tibor Digana
72830b8d82bd068ab7da5eaeb4da8a66b8ea600d
http://maven.apache.org/surefire-archives/surefire-LATEST/
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
Cheers
Tibor

---------------------------------------------------------------------

Enrico Olivelli

2018-11-05 17:08:13 UTC

Permalink

+1 (non binding)
Checked checksums
Built and run its on Linux (Fedora 27) on JDK8
Tested with projects on JDK11, with large use of JUnit categories

Enrico

Post by Tibor Digana
Well, yes there should be two repos.
One is Maven Central and the second is the staging because the ASF staging
Nexus is not a copy of Central. There are only our Apache artifacts
deployed.

Post by Tibor Digana
Hi,

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC

Post by Tibor Digana

Post by Eric Lilja

Post by Tibor Digana
https://repository.apache.org/content/repositories/maven-1466/

https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip

Post by Tibor Digana

Post by Eric Lilja
2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5

d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94

Post by Tibor Digana

Post by Eric Lilja

---------------------------------------------------------------------

--
-- Enrico Olivelli

Christian Stein

2018-11-05 18:23:19 UTC

Permalink

+1

Nit: some transitive dependency requires "asm-7.0-beta" -- should be
updated to GA version of ASM 7.0

Cheers,
Christian

Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/maven-surefire-common/3.0.0-M1/maven-surefire-common-3.0.0-M1.pom
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/maven-surefire-common/3.0.0-M1/maven-surefire-common-3.0.0-M1.pom
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/maven-surefire-common/3.0.0-M1/maven-surefire-common-3.0.0-M1.pom
(9.7 kB at 8.3 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-api/3.0.0-M1/surefire-api-3.0.0-M1.pom
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-api/3.0.0-M1/surefire-api-3.0.0-M1.pom
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-api/3.0.0-M1/surefire-api-3.0.0-M1.pom
(3.5 kB at 3.4 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-logger-api/3.0.0-M1/surefire-logger-api-3.0.0-M1.pom
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-logger-api/3.0.0-M1/surefire-logger-api-3.0.0-M1.pom
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-logger-api/3.0.0-M1/surefire-logger-api-3.0.0-M1.pom
(2.0 kB at 1.9 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-booter/3.0.0-M1/surefire-booter-3.0.0-M1.pom
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-booter/3.0.0-M1/surefire-booter-3.0.0-M1.pom
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-booter/3.0.0-M1/surefire-booter-3.0.0-M1.pom
(7.4 kB at 7.3 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/maven-toolchain/3.0-alpha-2/maven-toolchain-3.0-alpha-2.pom
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/maven-toolchain/3.0-alpha-2/maven-toolchain-3.0-alpha-2.pom
(2.2 kB at 7.1 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/maven/3.0-alpha-2/maven-3.0-alpha-2.pom
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/maven/3.0-alpha-2/maven-3.0-alpha-2.pom
(21 kB at 125 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/codehaus/plexus/plexus-java/0.9.11/plexus-java-0.9.11.pom
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/codehaus/plexus/plexus-java/0.9.11/plexus-java-0.9.11.pom
(4.6 kB at 33 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/codehaus/plexus/plexus-languages/0.9.11/plexus-languages-0.9.11.pom
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/codehaus/plexus/plexus-languages/0.9.11/plexus-languages-0.9.11.pom
(4.1 kB at 29 kB/s)

Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/ow2/asm/asm/7.0-beta/asm-7.0-beta.pom
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/ow2/asm/asm/7.0-beta/asm-7.0-beta.pom
(2.9 kB at 24 kB/s)

Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/maven-surefire-common/3.0.0-M1/maven-surefire-common-3.0.0-M1.jar
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/maven-toolchain/3.0-alpha-2/maven-toolchain-3.0-alpha-2.jar
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-booter/3.0.0-M1/surefire-booter-3.0.0-M1.jar
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-logger-api/3.0.0-M1/surefire-logger-api-3.0.0-M1.jar
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-api/3.0.0-M1/surefire-api-3.0.0-M1.jar
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/maven-toolchain/3.0-alpha-2/maven-toolchain-3.0-alpha-2.jar
(36 kB at 124 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/codehaus/plexus/plexus-java/0.9.11/plexus-java-0.9.11.jar
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/codehaus/plexus/plexus-java/0.9.11/plexus-java-0.9.11.jar
(50 kB at 108 kB/s)

Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/ow2/asm/asm/7.0-beta/asm-7.0-beta.jar
Downloaded from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/ow2/asm/asm/7.0-beta/asm-7.0-beta.jar
(114 kB at 173 kB/s)

Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/maven-surefire-common/3.0.0-M1/maven-surefire-common-3.0.0-M1.jar
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-booter/3.0.0-M1/surefire-booter-3.0.0-M1.jar
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-logger-api/3.0.0-M1/surefire-logger-api-3.0.0-M1.jar
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-api/3.0.0-M1/surefire-api-3.0.0-M1.jar
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-logger-api/3.0.0-M1/surefire-logger-api-3.0.0-M1.jar
(13 kB at 12 kB/s)
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-api/3.0.0-M1/surefire-api-3.0.0-M1.jar
(178 kB at 90 kB/s)
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-booter/3.0.0-M1/surefire-booter-3.0.0-M1.jar
(312 kB at 154 kB/s)
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/maven-surefire-common/3.0.0-M1/maven-surefire-common-3.0.0-M1.jar
(625 kB at 253 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-junit-platform/3.0.0-M1/surefire-junit-platform-3.0.0-M1.jar
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-junit-platform/3.0.0-M1/surefire-junit-platform-3.0.0-M1.jar
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-junit-platform/3.0.0-M1/surefire-junit-platform-3.0.0-M1.jar
(20 kB at 15 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-junit-platform/3.0.0-M1/surefire-junit-platform-3.0.0-M1.pom
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-junit-platform/3.0.0-M1/surefire-junit-platform-3.0.0-M1.pom
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-junit-platform/3.0.0-M1/surefire-junit-platform-3.0.0-M1.pom
(5.5 kB at 5.1 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/surefire-providers/3.0.0-M1/surefire-providers-3.0.0-M1.pom
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-providers/3.0.0-M1/surefire-providers-3.0.0-M1.pom
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire-providers/3.0.0-M1/surefire-providers-3.0.0-M1.pom
(2.5 kB at 2.4 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.pom
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.pom
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.pom
(3.1 kB at 2.9 kB/s)
Downloading from xwiki-releases:
http://nexus.xwiki.org/nexus/content/groups/public/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
Downloading from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
Downloaded from staged-releases:
https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
(32 kB at 26 kB/s)

Tamás Cservenák

2018-11-05 18:52:55 UTC

Permalink

Olivier Lamy

2018-11-05 23:19:24 UTC

Permalink

--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Tibor Digana

2018-11-06 18:43:30 UTC

Permalink

+1, we need to have more participants in the Vote.

Sylwester Lachiewicz

2018-11-06 19:35:34 UTC

Permalink

Post by Tibor Digana
+1, we need to have more participants in the Vote.

Post by Tibor Digana
Hi,

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC

Post by Tibor Digana
https://repository.apache.org/content/repositories/maven-1466/

Karl Heinz Marbaise

2018-11-07 07:11:52 UTC

Permalink

Hi,

here is my +1 ...
Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org

Tibor Digana

2018-11-07 10:46:14 UTC

Permalink

The vote has passed with the following result:

+1 : Eric Lilja, Enrico Olivelli, Christian Stein, TamÃ¡s CservenÃ¡k, Olivier
Lamy, Tibor Digana, Sylwester Lachiewicz, Karl Heinz Marbaise
0 : none
-1 : none.

PMC quorum: accomplished.

Tibor Digana

2018-11-07 10:51:57 UTC

Permalink

--
Cheers
Tibor