Discussion:
ARCHETYPE-536 Update Groovy Dependency and Include Ivy Dependency
Stefan Seifert
2018-08-08 11:21:43 UTC
Permalink
hello!

some months ago i submitted a small but important patch to the archetype plugin to update it's groovy dependency and add and dependency to ivy as well. this allows to include 3rdparty libraries in the archetype-post-generate.groovy script.

https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20

any chance to get it applied?

stefan


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org
Robert Scholte
2018-08-08 20:36:11 UTC
Permalink
bq. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.

Can you also provide an integration test[1] how this should work?

thanks,
Robert

[1]
https://github.com/apache/maven-archetype/tree/master/maven-archetype-plugin/src/it/projects

On Wed, 08 Aug 2018 13:21:43 +0200, Stefan Seifert
Post by Stefan Seifert
hello!
some months ago i submitted a small but important patch to the archetype
plugin to update it's groovy dependency and add and dependency to ivy as
well. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
any chance to get it applied?
stefan
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org
Stefan Seifert
2018-08-11 09:02:51 UTC
Permalink
sure - i've added a integration test validating the groovy grape behavior.

stefan
-----Original Message-----
Sent: Wednesday, August 8, 2018 10:36 PM
To: Maven Developers List
Subject: Re: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
bq. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
Can you also provide an integration test[1] how this should work?
thanks,
Robert
[1]
https://github.com/apache/maven-archetype/tree/master/maven-archetype-
plugin/src/it/projects
On Wed, 08 Aug 2018 13:21:43 +0200, Stefan Seifert
Post by Stefan Seifert
hello!
some months ago i submitted a small but important patch to the archetype
plugin to update it's groovy dependency and add and dependency to ivy as
well. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
any chance to get it applied?
stefan
---------------------------------------------------------------------
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org
Stefan Seifert
2018-08-16 07:49:55 UTC
Permalink
can you give it a look? the change is only minimal, integration test is included and runs fine.
i need it for an archetype i'm working on currently.

https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20

thanks!

stefan
-----Original Message-----
Sent: Saturday, August 11, 2018 11:03 AM
To: Maven Developers List
Subject: RE: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
sure - i've added a integration test validating the groovy grape behavior.
stefan
-----Original Message-----
Sent: Wednesday, August 8, 2018 10:36 PM
To: Maven Developers List
Subject: Re: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
bq. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
Can you also provide an integration test[1] how this should work?
thanks,
Robert
[1]
https://github.com/apache/maven-archetype/tree/master/maven-archetype-
plugin/src/it/projects
On Wed, 08 Aug 2018 13:21:43 +0200, Stefan Seifert
Post by Stefan Seifert
hello!
some months ago i submitted a small but important patch to the archetype
plugin to update it's groovy dependency and add and dependency to ivy as
well. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
any chance to get it applied?
stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org
Robert Scholte
2018-08-16 15:39:58 UTC
Permalink
Our CI servers were having issues, which makes it quite hard to confirm
that everything still works as expected.
It should now be okay again.

Robert

On Thu, 16 Aug 2018 09:49:55 +0200, Stefan Seifert
Post by Stefan Seifert
can you give it a look? the change is only minimal, integration test is
included and runs fine.
i need it for an archetype i'm working on currently.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
thanks!
stefan
-----Original Message-----
Sent: Saturday, August 11, 2018 11:03 AM
To: Maven Developers List
Subject: RE: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
sure - i've added a integration test validating the groovy grape behavior.
stefan
-----Original Message-----
Sent: Wednesday, August 8, 2018 10:36 PM
To: Maven Developers List
Subject: Re: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
bq. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
Can you also provide an integration test[1] how this should work?
thanks,
Robert
[1]
https://github.com/apache/maven-archetype/tree/master/maven-archetype-
plugin/src/it/projects
On Wed, 08 Aug 2018 13:21:43 +0200, Stefan Seifert
Post by Stefan Seifert
hello!
some months ago i submitted a small but important patch to the archetype
plugin to update it's groovy dependency and add and dependency to ivy as
well. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
any chance to get it applied?
stefan
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org
Robert Scholte
2018-08-16 18:56:06 UTC
Permalink
Cheered a bit too early.

https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-archetype/job/ARCHETYPE-553/
needs to be green first. After that it can be merged and can have a look
at your patch.

thanks,
Robert
Post by Robert Scholte
Our CI servers were having issues, which makes it quite hard to confirm
that everything still works as expected.
It should now be okay again.
Robert
On Thu, 16 Aug 2018 09:49:55 +0200, Stefan Seifert
Post by Stefan Seifert
can you give it a look? the change is only minimal, integration test is
included and runs fine.
i need it for an archetype i'm working on currently.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
thanks!
stefan
-----Original Message-----
Sent: Saturday, August 11, 2018 11:03 AM
To: Maven Developers List
Subject: RE: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
sure - i've added a integration test validating the groovy grape behavior.
stefan
-----Original Message-----
Sent: Wednesday, August 8, 2018 10:36 PM
To: Maven Developers List
Subject: Re: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
bq. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
Can you also provide an integration test[1] how this should work?
thanks,
Robert
[1]
https://github.com/apache/maven-archetype/tree/master/maven-archetype-
plugin/src/it/projects
On Wed, 08 Aug 2018 13:21:43 +0200, Stefan Seifert
Post by Stefan Seifert
hello!
some months ago i submitted a small but important patch to the archetype
plugin to update it's groovy dependency and add and dependency to ivy as
well. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
any chance to get it applied?
stefan
---------------------------------------------------------------------
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org
Stefan Seifert
2018-11-05 16:37:45 UTC
Permalink
it seems the build job is finally green.

can you have a look at the patch? integration tests included

https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20

thanks!

stefan
-----Original Message-----
Sent: Thursday, August 16, 2018 8:56 PM
To: Maven Developers List
Subject: Re: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
Cheered a bit too early.
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-
archetype/job/ARCHETYPE-553/
needs to be green first. After that it can be merged and can have a look
at your patch.
thanks,
Robert
Post by Robert Scholte
Our CI servers were having issues, which makes it quite hard to confirm
that everything still works as expected.
It should now be okay again.
Robert
On Thu, 16 Aug 2018 09:49:55 +0200, Stefan Seifert
Post by Stefan Seifert
can you give it a look? the change is only minimal, integration test is
included and runs fine.
i need it for an archetype i'm working on currently.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
thanks!
stefan
-----Original Message-----
Sent: Saturday, August 11, 2018 11:03 AM
To: Maven Developers List
Subject: RE: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
sure - i've added a integration test validating the groovy grape behavior.
stefan
-----Original Message-----
Sent: Wednesday, August 8, 2018 10:36 PM
To: Maven Developers List
Subject: Re: ARCHETYPE-536 Update Groovy Dependency and Include Ivy
Dependency
bq. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
Can you also provide an integration test[1] how this should work?
thanks,
Robert
[1]
https://github.com/apache/maven-archetype/tree/master/maven-archetype-
plugin/src/it/projects
On Wed, 08 Aug 2018 13:21:43 +0200, Stefan Seifert
Post by Stefan Seifert
hello!
some months ago i submitted a small but important patch to the archetype
plugin to update it's groovy dependency and add and dependency to ivy as
well. this allows to include 3rdparty libraries in the
archetype-post-generate.groovy script.
https://issues.apache.org/jira/browse/ARCHETYPE-536
https://github.com/apache/maven-archetype/pull/20
any chance to get it applied?
stefan
---------------------------------------------------------------------
---------------------------------------------------------------------
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@maven.apache.org
For additional commands, e-mail: dev-***@maven.apache.org

Loading...